use http for .onion content #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially solves #623
As mentioned in the comment in the issue, many .onion sites do not have SSL certs, and some even see them as detrimental. I have yet to see a v3 (super long 56 character addresses) address that can be accessed using
https://, including the CIA's, though I cannot confirm if there's something built in to these addresses that doesn't allow it.As a result of the above, this PR proposes connecting to .onion content using
http://, nothttps://. Since .onion sites are already end-to-end encrypted, this shouldn't weaken security. (Some sources linked in #623 in the comment.)